Austin/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2024-11-16 11:42:29 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix: vanna CVE-2024-5565 by disable visualize of ask func (#4930)

Browse Source
This commit is contained in:
takatost 2024-06-05 00:46:22 +08:00 committed by GitHub
parent 37f292ea91
commit 09298a32e7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
api/core/tools/provider/builtin/vanna/tools/vanna.py
View File

@ -102,7 +102,17 @@ class VannaTool(BuiltinTool):
if memos:
vn.train(documentation=memos)
generate_chart = tool_parameters.get("generate_chart", True)
#########################################################################################
# Due to CVE-2024-5565, we have to disable the chart generation feature
# The Vanna library uses a prompt function to present the user with visualized results,
# it is possible to alter the prompt using prompt injection and run arbitrary Python code
# instead of the intended visualization code.
# Specifically - allowing external input to the library’s “ask” method
# with "visualize" set to True (default behavior) leads to remote code execution.
# Affected versions: <= 0.5.5
#########################################################################################
generate_chart = False
# generate_chart = tool_parameters.get("generate_chart", True)
res = vn.ask(prompt, False, True, generate_chart)
result = []